Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix pytorch2.0 not support sys._getframe to remove private key #979

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Harold-lkk
Copy link
Collaborator

@Harold-lkk Harold-lkk commented Mar 6, 2023

Same for #690
PyTorch2.0 does not support sys._getframe, so we remove the redundant inner attribute created by the property function by removing the _ + property_name at the keys() function.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d34fb58). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 153ad8f differs from pull request most recent head a8380ff. Consider uploading reports for the commit a8380ff to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage        ?   76.56%           
=======================================
  Files           ?      139           
  Lines           ?    11036           
  Branches        ?     2207           
=======================================
  Hits            ?     8450           
  Misses          ?     2219           
  Partials        ?      367           
Flag Coverage Δ
unittests 76.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

C1rN09
C1rN09 previously approved these changes Mar 6, 2023
@HAOCHENYE HAOCHENYE added this to the 0.7.0 milestone Mar 6, 2023
@zhouzaida zhouzaida requested a review from ZwwWayne March 7, 2023 11:31
@zhouzaida zhouzaida merged commit 67ce04d into open-mmlab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants