Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] singan errors #192

Merged
merged 2 commits into from
Jan 7, 2022
Merged

[Fix] singan errors #192

merged 2 commits into from
Jan 7, 2022

Conversation

JiangongWang
Copy link
Contributor

math.log(a, b) is equal to np.log(a)/np.log(b)

@JiangongWang JiangongWang mentioned this pull request Dec 27, 2021
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #192 (09455b6) into master (3cd123b) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   75.52%   75.61%   +0.08%     
==========================================
  Files         127      128       +1     
  Lines        8814     8927     +113     
  Branches     1748     1781      +33     
==========================================
+ Hits         6657     6750      +93     
- Misses       1719     1728       +9     
- Partials      438      449      +11     
Flag Coverage Δ
unittests 75.61% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/datasets/singan_dataset.py 30.95% <ø> (ø)
...chitectures/biggan/generator_discriminator_deep.py 77.87% <0.00%> (-1.37%) ⬇️
...ls/architectures/biggan/generator_discriminator.py 77.72% <0.00%> (-1.30%) ⬇️
mmgen/models/architectures/biggan/modules.py 95.98% <0.00%> (-1.10%) ⬇️
...gen/models/architectures/biggan/biggan_snmodule.py 89.23% <0.00%> (ø)
mmgen/models/architectures/stylegan/mspie.py 91.58% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21c398...09455b6. Read the comment docs.

@JiangongWang JiangongWang changed the title fix np.log [Fix] singan errors Dec 27, 2021
@LeoXing1996 LeoXing1996 requested review from nbei and removed request for plyfager December 29, 2021 16:07
@LeoXing1996 LeoXing1996 merged commit 55c9a42 into open-mmlab:master Jan 7, 2022
LeoXing1996 added a commit that referenced this pull request Jul 16, 2022
LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants