Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1 secret per webhook pod to store the public/private key pairs #27

Open
maxsmythe opened this issue Jan 22, 2021 · 0 comments
Open

Comments

@maxsmythe
Copy link
Contributor

Keeping different secrets for different pods will allow gradual rotation, which will mitigate the downsides of an instantaneous rotation:

  • All pods restarting at once
  • If the new key is bad, there is no opportunity for admin detection/intervention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant