Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on usefulness of RestartOnSecretRefresh #47

Open
ahmetb opened this issue Sep 21, 2022 · 0 comments
Open

Question on usefulness of RestartOnSecretRefresh #47

ahmetb opened this issue Sep 21, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code

Comments

@ahmetb
Copy link

ahmetb commented Sep 21, 2022

Follow up to #44, it appears that 4842e47 added the RestartOnSecretRefresh, which restarts the process (os.Exit(0)) every time refreshCerts() is called, to update the Secret.

That said, Kubernetes typically takes ~up to 1 minute delivering the secret to kubelet (easily reproducible on minikube, or kind, or a GKE cluster) with default kubelet configurations.

Since the delivery of updated Secret to the Pod is not instant (or even a duration that can be considered quick), what makes the os.Exit(0) useful if the kubelet will still serve the old Secret upon the restart?

cc: @stijndehaes

@srenatus srenatus added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code
Projects
None yet
Development

No branches or pull requests

2 participants