Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tagging submodule "constraint"? #294

Open
Rick-xuy opened this issue Feb 17, 2023 · 0 comments
Open

Consider tagging submodule "constraint"? #294

Rick-xuy opened this issue Feb 17, 2023 · 0 comments

Comments

@Rick-xuy
Copy link

I found that packages, say github.com/open-policy-agent/frameworks/constraint/pkg/client, are placed in submodule github.com/open-policy-agent/frameworks/constraint instead of root module.

However, it seems that submodule github.com/open-policy-agent/frameworks/constraint is not tagged. According to Go Modules wiki, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/open-policy-agent/frameworks/constraint/pkg/client, downstream would depends on pseudo-version of module github.com/open-policy-agent/frameworks/constraint.

github.com/open-policy-agent/frameworks/constraint v0.0.0-20220121182312-5d06dedcafb4

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, constraint/v0.0.1, constraint/v0.8.0etc, so that other project can use tag to import this module in go.mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant