Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving match criteria debuggability #328

Open
acpana opened this issue May 19, 2023 · 2 comments
Open

improving match criteria debuggability #328

acpana opened this issue May 19, 2023 · 2 comments

Comments

@acpana
Copy link
Contributor

acpana commented May 19, 2023

At present, we only record results that match a constraint match criteria:

for name, constraint := range e.constraints {
cResult := constraint.matches(target, review)
if cResult != nil {
result[name] = *cResult
}
}

We can improve the debuggability of the system by A) indicating that a constraint doesn't match for a review and B) any stats on time it takes to run the match for a constraint. Both of these can help with UX efforts in shift left case scenarios like open-policy-agent/gatekeeper#2599

@maxsmythe
Copy link
Contributor

What is a "shift case scenario"?

@maxsmythe
Copy link
Contributor

"shift left"? The time of enforcement is irrelevant WRT its usefulness.

That being said, it should be opt-in for the purpose of limiting verbosity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants