AST: Allow jsonOptions to include Text field of Location struct

[anderseknert]

Similarly to what was previously done in order to include the location in the parsed AST, it would be useful for tools like Regal to be able to use the Text field of the Location struct. This is however currently lost in serialization.

If we could add a JSON option to have that optionally included in location data, it would be helpful to solve a certain class of problems in external tooling.

[charlieegan3]

I've looked into this a bit this afternoon, we have an alias type Location in the ast package.

opa/ast/term.go

Line 32 in 0431567

type Location = location.Location

This is the type that's used to for all the ast Term Location values, and forms the majority of Locations used in the ast Go API.

It aliases the location.Location type:

opa/ast/location/location.go

Line 14 in 2131da3

Row int `json:"row"` // The line in the source.

This is used more sparingly in ast & topdown.

I'm unsure of the history as to why we have the alias (#2219). However, it makes it harder to implement this feature as we can't add functions to the alias type required to alter the marshalling behaviour.

Open to other ideas 🙂

[charlieegan3]

Update, #6234 should be a working fix for this issue. My comment above was based on a mistake I made in testing!

[anderseknert]

Niiiiice!