From 8221eecc375902c3532d50bb6f796f59c583dc32 Mon Sep 17 00:00:00 2001 From: Mahesh Kumar G <94525128+mahi657@users.noreply.github.com> Date: Mon, 20 May 2024 14:47:10 +0530 Subject: [PATCH] Update PowerNVDump.py with review comments --- testcases/PowerNVDump.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/testcases/PowerNVDump.py b/testcases/PowerNVDump.py index c7a966ca..be80bfac 100644 --- a/testcases/PowerNVDump.py +++ b/testcases/PowerNVDump.py @@ -170,7 +170,6 @@ def setup_pwdless_auth(self): self.c.run_command( "ssh-keygen -q -t rsa -f %s -P ''" % self.rsa_path) self.c.run_command("chmod 400 %s" % self.rsa_path) - (self.dump_server_pw, self.rsa_path, self.dump_server_ip)) self.c.run_command("sshpass -p %s ssh-copy-id -o \"StrictHostKeyChecking no\" -i %s %s@%s" % (self.dump_server_pw, self.rsa_path, self.dump_server_user, self.dump_server_ip)) except CommandFailed: @@ -295,10 +294,7 @@ def verify_dump_file(self, boot_type=BootType.NORMAL, dump_place="local"): else: msg = "Dump directory not created" raise OpTestError(msg) - if self.dump_server_user != 'root': - #cannot delete with normal user since dump dir is owned by root - pass - else: + if self.dump_server_user == 'root': self.c.run_command("rm -rf /var/crash/%s; sync" % self.crash_content[0]) def verify_fadump_reg(self):