Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force gcc 13.2.0 over 13.3.0 #1805

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

planetf1
Copy link
Contributor

Attempts to verify cause of recent build failures by patching the gcc compiler for macOS 13.3.0 -> 13.2.0

See issue #1804

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@planetf1
Copy link
Contributor Author

Pushed a second commit, which comments out the change. This is to validate that it is this gcc revert that fixes the build -- in case the cause is another external problem

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
…(and this fails)

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
@planetf1 planetf1 marked this pull request as ready for review June 4, 2024 17:02
@planetf1 planetf1 requested a review from dstebila as a code owner June 4, 2024 17:02
@planetf1
Copy link
Contributor Author

planetf1 commented Jun 4, 2024

OQS status meeting 2024-06-04 agreed ok to go with workaround, but keep issue open to revert

@praveksharma praveksharma self-requested a review June 4, 2024 19:08
@dstebila dstebila merged commit 0a89cf6 into open-quantum-safe:main Jun 5, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants