Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable erroring TravisCI build" #1960

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Revert "Disable erroring TravisCI build" #1960

merged 3 commits into from
Nov 11, 2024

Conversation

bhess
Copy link
Member

@bhess bhess commented Oct 24, 2024

This reverts commit b59d78c.

Travis build issue has been resolved, re-enabling the build.

To resolve: CROSS KATs on s390x fail, endianness issues?

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4
Copy link
Member

SWilson4 commented Oct 30, 2024

Would it be a good idea / is it possible to skip CROSS in these tests for now (perhaps mark it as only supported on little-endian systems) so we can get Travis running on main again?

README.md Outdated Show resolved Hide resolved
This reverts commit b59d78c.

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
@bhess
Copy link
Member Author

bhess commented Nov 5, 2024

Would it be a good idea / is it possible to skip CROSS in these tests for now (perhaps mark it as only supported on little-endian systems) so we can get Travis running on main again?

I agree, updating the PR accordingly.

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
@baentsch baentsch merged commit e26d36e into main Nov 11, 2024
87 checks passed
@baentsch baentsch deleted the bhe-reenable-travis branch November 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants