-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor typos in documentation #304
Fix minor typos in documentation #304
Conversation
Looking at the failing CI tests for mac OS, looks like it is failing here: https://github.com/open-quantum-safe/oqs-provider/blob/mb-newpolicy/.circleci/config.yml#L304 and L307 while trying to pre-install OpenSSL v3.1. Currently the stable version supported for |
For reference, this is the PR where the changes were made. @thb-sb fyi |
Fixed minor typos and incorrect links in README.md and STANDARDS.md
6275eb8
to
671dd1f
Compare
I just added the [skip ci] tag to skip all CI tests since this is a doc change. So all looks good now but the other issue with the CI tests on mac still exists. OpenSSL v3.2 was just released last week. |
That would be appreciated. Our approach is to immediately fix issues if we know there'd be something breaking (new, full) CI runs: Those should test new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these improvements!
Hi @johnma14, |
@baentsch @thb-sb I will go ahead and submit a PR right away to fix it. Thank you. |
Fixed minor typos and incorrect links in README.md and STANDARDS.md Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fixed minor typos and incorrect links in README.md and STANDARDS.md Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fixed minor typos and incorrect links in README.md and STANDARDS.md Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fixed minor typos and incorrect links in README.md and STANDARDS.md Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fixed minor typos and incorrect links in README.md and STANDARDS.md Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fixed minor typos and incorrect links in README.md and STANDARDS.md