Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more defensive error handling #346

Merged
merged 4 commits into from
Feb 3, 2024
Merged

add more defensive error handling #346

merged 4 commits into from
Feb 3, 2024

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Feb 2, 2024 •
edited
Loading

  • Guards more (hopefully now all) memory allocation locations for errors returned
  • Be more explicit about error exit locations enabling better code readability

Kudos to the team of RadicallyOpenSecurity.

@baentsch baentsch requested review from a user and bhess February 2, 2024 10:49
@baentsch baentsch marked this pull request as ready for review February 2, 2024 10:49
ghost
ghost reviewed Feb 2, 2024
View reviewed changes
oqsprov/oqsprov_keys.c Show resolved Hide resolved
oqsprov/oqsprov_keys.c Show resolved Hide resolved
bhess
bhess reviewed Feb 2, 2024
View reviewed changes
oqsprov/oqsprov_keys.c Outdated Show resolved Hide resolved
bhess
bhess approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@baentsch baentsch merged commit 0457f04 into main Feb 3, 2024
44 checks passed
@baentsch baentsch deleted the mb-fixmallocs branch February 3, 2024 16:03
@baentsch
Copy link
Member Author

baentsch commented Feb 8, 2024

Tagging @pcwizz for review

pcwizz
pcwizz reviewed Feb 8, 2024
View reviewed changes
Copy link

@pcwizz pcwizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a check and can't find any more unguarded allocations. Good work.

feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
@baentsch @feventura
add more defensive error handling (open-quantum-safe#346)
906ce53 
* add more defensive error handling
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
@baentsch @feventura
add more defensive error handling (open-quantum-safe#346)
3dd0bd8 
* add more defensive error handling

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
@baentsch @feventura
add more defensive error handling (open-quantum-safe#346)
b2fe150 
* add more defensive error handling
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
@baentsch @feventura
add more defensive error handling (open-quantum-safe#346)
bb47246 
* add more defensive error handling
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
@baentsch @feventura
add more defensive error handling (open-quantum-safe#346)
8e85bb4 
* add more defensive error handling

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwizz pcwizz pcwizz left review comments

@bhess bhess bhess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baentsch @bhess @pcwizz