add explicit usage warning [skip ci] #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
…kip ci] Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
SWilson4
reviewed
Sep 12, 2024
SWilson4
approved these changes
Sep 12, 2024
dstebila
approved these changes
Sep 12, 2024
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
bhess
approved these changes
Sep 12, 2024
ashman-p
pushed a commit
to ashman-p/oqs-provider-fix-warnings
that referenced
this pull request
Sep 13, 2024
* add explicit usage warning [skip ci] Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * copying the liboqs core warning over to avoid any misunderstanding [skip ci] Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * Update README.md Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * disable CF hybrid interop testing Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> --------- Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Norman Ashley <nashley@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NIST standardization process seems to be moving faster than this project can follow. At the same time, more and more security concerns and actual bugs become visible that need resolution, e.g., #514, #483.
This PR therefore adds explicit language warning users of the current state of affairs, particularly in light of the upcoming release cycle it seems prudent to add language that winds up in the (to-be-)release(d) README.