-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Lifts and doors not positioned correctly by fiducials #505
Comments
Hello @Vortex-TH! Just to make sure I understand the problem clearly, the issue here is currently related to the rviz visualizations, where the doors and lift positions are not aligned with the floor plan? Could you share the modified Yeah the simulation looks alright, have you tried running some patrol tasks with the robots, such that they attempt to go through doors and lifts? That can help narrow down where the issue is. rmf visualizations on rviz is generally using the same building map file that generates the simulation, so there should not be any discrepancies. Some sanity checks,
|
Sure, here is my updated hotel.building.yaml and also my modified hotel_L2.png hotel.building.yaml
The first issue is that the lift position/rotation is obviously not updated correctly in traffic editor for L2. And yes, the positions in Rviz are not displayed correctly (maybe this is a seperate issue). I didn't do any robot tasks because I would assume that the robot positions in L2 are incorrect anyway because in the demo there are no level specific reference coordinates in the robot config for the coordinate transformations. But I'll see if I can get it to work. |
I see what you mean now
The lift position is not tied to the waypoints or vertices in the traffic editor, hence it will not be updated. The only connection is the designated waypoint within the lift. You will just need to
|
@aaronchongth Could you have another look at this? My assumption was that I only position the lift once in L1, because that is the reference floor. The position, orientation and scale of the lift on the other floors should then be automatically derived from that by the traffic editor based on the fiducial markers. |
I see what you mean about the orientation across levels, I'll reopen this issue and take a look at it |
HI @aaronchongth, I opened up a PR with the graphic fix for the lift cabin. We still need to fix the alignment for the Should we implement the drawing of The consideration is that for the first method, we will need to pass the The second method might be cleaner but might affect the interaction with the vertex, such as being unable to click and select the Please advice. |
Hey @TanJunKiat! Thanks for adding the fix, I'll be looking into it momentarily. Off the top of my head, I would agree that the second method would be ideal, and semantically more accurate too. As for being able to select the lift vertex on the UI or not, if it comes to it, the backup plan could be to set the I'll go through the changes and put up any other comments I have in the PR |
@aaronchongth hi! Have you updated this issue? I also have this issue and have no solution yet. Two maps on RMF-Traffic Editor and You can see position and rotation of Lift is wrong |
Some updates on this. After thinking about it and looking at the code, I feel there is a better approach to the problem on The baseline is that vertices are defined in the level's coordinate in the The objective for the lift cabin alignment is to get the coordinates of the We also need to ensure that the users can only move the I uploaded a commit based on these and the following pointers are the summary of change:
I will see what else can be optimize in the new codes and check for potential bugs, but the fix seems to be working for now. |
This issue is now fixed by #513 This one was a community effort, so I want to give special thanks to @Vortex-TH for the detailed and reproducible report, @aaronchongth for triaging the problem, and @TanJunKiat for delivering the solution. Community contributions like this are greatly appreciated! |
Before proceeding, is there an existing issue or discussion for this?
OS and version
Ubuntu 22.04.3
Open-RMF installation type
Binaries
Other Open-RMF installation methods
No response
Open-RMF version or commit hash
https://github.com/open-rmf/rmf/releases/tag/release-iron-231229
ROS distribution
Iron
ROS installation type
Binaries
Other ROS installation methods
No response
Package or library, if applicable
No response
Description of the bug
I had some relocalization and map issues when my bot arrives at L2 (coming from L1 with the lift), so I did some tests with the hotel demo, which makes me think there are some bugs with the map building tools.
I am using the iron branch of rmf_demos and started the hotel demo, which works fine:
ros2 launch rmf_demos_gz hotel.launch.xml
I then did the following:
Steps to reproduce the bug
Expected behavior
The lift and doors should be correctly positioned.
Actual behavior
No response
Additional information or screenshots
Image 1
Image 2
Image 3
Image 4
Image 5
The text was updated successfully, but these errors were encountered: