From 844af195ac1098002630b68a309f03fe1a8e519c Mon Sep 17 00:00:00 2001
From: shanejonas <jonas.shane@gmail.com>
Date: Wed, 23 Sep 2020 16:01:53 -0700
Subject: [PATCH] fix: remove PostMessage EventListener on close

---
 src/transports/PostMessageWindowTransport.ts | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/transports/PostMessageWindowTransport.ts b/src/transports/PostMessageWindowTransport.ts
index 9541d85..cc9be8a 100644
--- a/src/transports/PostMessageWindowTransport.ts
+++ b/src/transports/PostMessageWindowTransport.ts
@@ -24,6 +24,7 @@ class PostMessageTransport extends Transport {
     this.uri = uri;
     this.postMessageID = `post-message-transport-${Math.random()}`;
   }
+
   public createWindow(uri: string): Promise<Window | null> {
     return new Promise((resolve, reject) => {
       let frame: Window | null;
@@ -33,6 +34,14 @@ class PostMessageTransport extends Transport {
       }, 3000);
     });
   }
+
+  private messageHandler = (ev: MessageEvent) => {
+    if (ev.origin === window.origin) {
+      return;
+    }
+    this.transportRequestManager.resolveResponse(JSON.stringify(ev.data));
+  }
+
   public connect(): Promise<any> {
     const urlRegex = /^(http|https):\/\/.*$/;
     return new Promise(async (resolve, reject) => {
@@ -40,12 +49,7 @@ class PostMessageTransport extends Transport {
         reject(new Error("Bad URI"));
       }
       this.frame = await this.createWindow(this.uri);
-      window.addEventListener("message", (ev: MessageEvent) => {
-        if (ev.origin === window.origin) {
-          return;
-        }
-        this.transportRequestManager.resolveResponse(JSON.stringify(ev.data));
-      });
+      window.addEventListener("message", this.messageHandler);
       resolve();
     });
   }
@@ -60,6 +64,7 @@ class PostMessageTransport extends Transport {
 
   public close(): void {
     if (this.frame) {
+      window.removeEventListener("message", this.messageHandler);
       (this.frame as Window).close();
     }
   }