Feature: Update manifest version after release

[bdougie]

Type of feature

🍕 Feature

Current behavior

When a release is made, the tag is created and the package package.json version is bump using open-sauced/release. The manifest file is not updated during this process.

https://github.com/open-sauced/browser-extensions/blob/beta/manifest.json#L4

Suggested solution

Create a script in this repo that bumps the version. This does not need to be added to the open-sauced/release project since this is specific to the browser extension.

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[0-vortex]

@bdougie this is not possible without modifying release, unless you want to stop using that across our repos

[bdougie]

Do you have a solution?

[bdougie]

Do you have a solution?

I suppose we can check for the existence of the manifest.json in open-sauced/release and from there.

[0-vortex]

Do you have a solution?

Described the solution previously, needs another object in this array: https://github.com/open-sauced/release/blob/c151ff0773a49f195c3b4dcf3dc22d85d9220665/release.config.js#L108-L121

[Anush008]

We can utilize a separate workflow that executes after release. This workflow will fetch the version number from package.json and apply it to the manifest.json file.
I tried using the json cli to bump the file version in place. The test runs can be found here. https://github.com/Anush008/browser-extensions/actions. I'll open a PR for review after testing it out a few more times.

[Anush008]

After some digging and trials I found that the bump job can be part of the release CI and doesn't need to be a separate workflow. I've updated the workflow and opened a PR.

[mtfoley]

For the extensions I maintain for work, the manifest version is not in the source files, and is calculated in build steps based on Git tags. One fundamental difference though is that we do version bumps at the very beginning of build steps - it's just that the release commits only get pushed in deploy jobs (thrown out otherwise) - honestly I think we only add tags, no release commits end up being needed. There are no commits associated with the manifest bump since a) we don't hold the version number in source files and b) we don't track the dist directory in source control.

We also do manual tests before uploading to store and we use zip file artifacts from CI to upload rather than building locally than uploading (don't know what's being done here).

I think it's different enough that it's probably not helpful but perhaps a different perspective.

[github-actions]

🎉 This issue has been resolved in version 1.2.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀