Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use Split Button Component for SBOM and Repository Workspace Creation on Repository Page #3942

Closed
nickytonline opened this issue Aug 13, 2024 · 4 comments · Fixed by #4062

Comments

@nickytonline
Copy link
Member

nickytonline commented Aug 13, 2024

          > @bdougie I was going to say the same thing, two primary buttons is a bit too much. I'm ok with the secondary dark version to get it out the door, but the follow up should definitely add a dropdown button.

However we do have the dropdown component, so I wonder if this would be just good enough for now? For example: image

And we can work on a similar component but with a primary button + a down arrow as the dropdown trigger for a follow up

Yeah I think that's the SingleSelect component? I can do a fast follow up on this using that.

Originally posted by @nickytonline in #3938 (comment)

Depends on #4041 (should be merged soon)

@nickytonline nickytonline self-assigned this Aug 13, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added 📲 mobile-first Related to mobile and making OpenSauced mobile first repo-pages sbom and removed 📲 mobile-first Related to mobile and making OpenSauced mobile first labels Aug 13, 2024
@nickytonline
Copy link
Member Author

I can get to this when I'm back but essentially this comment has an implementation of this. shadcn-ui/ui#813 (comment)

@nickytonline nickytonline changed the title Feature: Multibutton Component for SBOM and Repository Workspace Creation on Repository Page Feature: Split Button Component Aug 27, 2024
@nickytonline nickytonline changed the title Feature: Split Button Component Feature: Use Split Button Component for SBOM and Repository Workspace Creation on Repository Page Aug 27, 2024
Copy link
Contributor

open-sauced bot commented Aug 30, 2024

🎉 This issue has been resolved in version 2.62.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Sep 10, 2024

🎉 This issue has been resolved in version 2.62.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants