feat: now the dev card page is cached for one hour #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
force-pushed
the
nickytonline/cache-dev-card-page
branch
from
4eadff5
to
9548844
Compare
nickytonline
changed the title
zeucapua
approved these changes
Aug 16, 2024
BekahHW
approved these changes
Aug 16, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## [2.58.0-beta.3](v2.58.0-beta.2...v2.58.0-beta.3) (2024-08-16) ### 🍕 Features * now the dev card page is cached for one hour ([#3968](#3968)) ([d070065](d070065))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## [2.58.0](v2.57.0...v2.58.0) (2024-08-16) ### 🐛 Bug Fixes * better DevCard data fetching flow ([#3936](#3936)) ([a5371ee](a5371ee)) ### 🍕 Features * add button to copy DevCard image to clipboard ([#3943](#3943)) ([d15ea8c](d15ea8c)) * add redirect for oscr.me to DevCard ([#3973](#3973)) ([88853aa](88853aa)) * implemented utility function to copy an HTML element as an image to the clipboard ([#3963](#3963)) ([35a3ffe](35a3ffe)) * now the dev card page is cached for one hour ([#3968](#3968)) ([d070065](d070065))
|
TLDR in prod Production (no caching dev card page) Production (caching dev card page) Production (no caching dev card page) oha --no-tui https://app.opensauced.pizza/u/nickytonline/card
Summary:
Success rate: 100.00%
Total: 65.2750 secs
Slowest: 20.1116 secs
Fastest: 4.1734 secs
Average: 14.5518 secs
Requests/sec: 3.0640
Total data: 308.39 KiB
Size/request: 1.54 KiB
Size/sec: 4.72 KiB
Response time histogram:
4.173 [1] |
5.767 [1] |
7.361 [1] |
8.955 [1] |
10.549 [4] |■
12.142 [47] |■■■■■■■■■■■■■■■■■■
13.736 [26] |■■■■■■■■■■
15.330 [12] |■■■■
16.924 [81] |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■
18.518 [5] |■
20.112 [21] |■■■■■■■■
Response time distribution:
10.00% in 10.7409 secs
25.00% in 11.9511 secs
50.00% in 15.9991 secs
75.00% in 16.3893 secs
90.00% in 19.6481 secs
95.00% in 19.9475 secs
99.00% in 20.0530 secs
99.90% in 20.1116 secs
99.99% in 20.1116 secs
Details (average, fastest, slowest):
DNS+dialup: 2.1186 secs, 2.0533 secs, 2.5430 secs
DNS-lookup: 0.0001 secs, 0.0000 secs, 0.0004 secs
Status code distribution:
[502] 182 responses
[200] 18 responsesProd (dev card with caching) ❯ oha --no-tui https://app.opensauced.pizza/u/nickytonline/card
Summary:
Success rate: 100.00%
Total: 11.8555 secs
Slowest: 8.6726 secs
Fastest: 0.0591 secs
Average: 2.8283 secs
Requests/sec: 16.8698
Total data: 1.06 MiB
Size/request: 5.45 KiB
Size/sec: 91.98 KiB
Response time histogram:
0.059 [1] |
0.920 [42] |■■■■■■■■■■■■■
1.782 [100] |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■
2.643 [4] |■
3.505 [2] |
4.366 [1] |
5.227 [3] |
6.089 [1] |
6.950 [2] |
7.811 [5] |■
8.673 [39] |■■■■■■■■■■■■
Response time distribution:
10.00% in 0.5818 secs
25.00% in 1.0299 secs
50.00% in 1.2463 secs
75.00% in 4.4452 secs
90.00% in 8.4557 secs
95.00% in 8.5052 secs
99.00% in 8.5946 secs
99.90% in 8.6726 secs
99.99% in 8.6726 secs
Details (average, fastest, slowest):
DNS+dialup: 2.1526 secs, 2.0857 secs, 2.5743 secs
DNS-lookup: 0.0002 secs, 0.0000 secs, 0.0027 secs
Status code distribution:
[200] 200 responses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caches the dev card page for one hour. I haven't made it super long yet, as there's a mechanism we need to put in place for profile pages and this page which is leveraging Netlify's purge of cache keys.
That said, one hour is still solid and stale while revalidate is in place, so it should perform well. The only reason I put an hour is if the bio changes or other stats (related to purge mentioned above).
Deploy Preview compared to Beta App's dev card page
TLDR;
With caching:
Slowest: 2.6015 secs
Fastest: 0.0161 secs
Current Beta Site (no caching)
Slowest: 17.4056 secs
Fastest: 4.4655 secs
Related Tickets & Documents
Close #3967
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?