Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect for oscr.me to DevCard #3973

Merged
merged 2 commits into from
Aug 16, 2024
Merged

feat: add redirect for oscr.me to DevCard #3973

merged 2 commits into from
Aug 16, 2024

Conversation

brandonroberts
Copy link
Contributor

Description

  • Adds a redirect for oscr.me/{username} to the respective DevCard URL for the username
  • Adds default redirect for oscr.me

Related Tickets & Documents

Closes #3917

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts requested review from BekahHW and a team August 16, 2024 18:22
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 7ef0f4b
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66bf9bc69a94680008f84cd4
😎 Deploy Preview https://deploy-preview-3973--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 7ef0f4b
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66bf9bc69cdd030008641902
😎 Deploy Preview https://deploy-preview-3973--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify.toml Outdated Show resolved Hide resolved
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brandonroberts brandonroberts added this pull request to the merge queue Aug 16, 2024
Merged via the queue into beta with commit 88853aa Aug 16, 2024
13 checks passed
@brandonroberts brandonroberts deleted the feat-oscr-me branch August 16, 2024 19:34
open-sauced bot pushed a commit that referenced this pull request Aug 16, 2024
## [2.58.0-beta.5](v2.58.0-beta.4...v2.58.0-beta.5) (2024-08-16)

### 🍕 Features

* add redirect for oscr.me to DevCard ([#3973](#3973)) ([88853aa](88853aa))
open-sauced bot pushed a commit that referenced this pull request Aug 16, 2024
## [2.58.0](v2.57.0...v2.58.0) (2024-08-16)

### 🐛 Bug Fixes

* better DevCard data fetching flow ([#3936](#3936)) ([a5371ee](a5371ee))

### 🍕 Features

* add button to copy DevCard image to clipboard ([#3943](#3943)) ([d15ea8c](d15ea8c))
* add redirect for oscr.me to DevCard ([#3973](#3973)) ([88853aa](88853aa))
* implemented utility function to copy an HTML element as an image to the clipboard ([#3963](#3963)) ([35a3ffe](35a3ffe))
* now the dev card page is cached for one hour ([#3968](#3968)) ([d070065](d070065))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Set up short links for profile
3 participants