Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dynamically import the html2canvas-pro package only when it's needed #4033

Closed
nickytonline opened this issue Aug 26, 2024 · 4 comments · Fixed by #4044
Closed

Feature: dynamically import the html2canvas-pro package only when it's needed #4033

nickytonline opened this issue Aug 26, 2024 · 4 comments · Fixed by #4044
Assignees

Comments

@nickytonline
Copy link
Member

As a developer of the OpenSauced platform, I want to dynamically import the html2canvas-pro package only when it's needed so that I save loading 45.3kB (Minified + Gzipped) only until it's needed.

https://bundlephobia.com/package/html2canvas@1.4.1

@nickytonline nickytonline added 💡 feature core team work Work that the OpenSauced core team takes on performance labels Aug 26, 2024
@nickytonline nickytonline self-assigned this Aug 26, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member Author

When I created the copyNodeAsImage utility function (#3963), it was a quick POC that turned into prod code. I hadn't checked the bundle size, so this will be a low lift easy perf win.

@nickytonline nickytonline changed the title Feature: Feature: dynamically import the html2canvas-pro package only when it's needed Aug 26, 2024
Copy link
Contributor

open-sauced bot commented Aug 27, 2024

🎉 This issue has been resolved in version 2.61.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Aug 29, 2024

🎉 This issue has been resolved in version 2.61.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant