Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove unnecessary z-index on OpenSSF score card I want this now button #4055

Closed
nickytonline opened this issue Aug 28, 2024 · 5 comments · Fixed by #4066
Closed

Bug: Remove unnecessary z-index on OpenSSF score card I want this now button #4055

nickytonline opened this issue Aug 28, 2024 · 5 comments · Fixed by #4066
Assignees
Labels
🐛 bug Something isn't working good first issue Good for newcomers released on @beta released

Comments

@nickytonline
Copy link
Member

nickytonline commented Aug 28, 2024

Remove the z-index from the <OssfChart /> components "I want this now!" button JSX and move the JSX below the <ResponsiveContainer /> component.

            <div className="relative w-full !max-w-[14rem] lg:max-w-full lg:mx-auto h-full lg:max-h-24 xl:h-full">
-              {isError && (
-                <div className="absolute inset-0 z-50 flex items-center justify-center">
-                  <Button variant="primary" onClick={onRequestClick} className="!text-xs">
-                    I want this now!
-                  </Button>
-                </div>
-              )}
              <ResponsiveContainer width="100%" height={150} className={`${isError && "blur-[2.5px]"}`}>...
              </ResponsiveContainer>
+              {isError && (
+                <div className="absolute inset-0 flex items-center justify-center">
+                  <Button variant="primary" onClick={onRequestClick} className="!text-xs">
+                    I want this now!
+                  </Button>
+                </div>
+              )}
            </div>

The file where the changes should be made is https://github.com/open-sauced/app/blob/beta/components/Repositories/OssfChart.tsx

zindices.mp4

Some additional reading for those interested:

@nickytonline nickytonline added good first issue Good for newcomers 🐛 bug Something isn't working labels Aug 28, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@ryandotfurrer
Copy link
Contributor

Feel free to assign this to me, I'll get it done tonight or tomorrow night.

@ryandotfurrer
Copy link
Contributor

.take

Copy link
Contributor

open-sauced bot commented Aug 29, 2024

🎉 This issue has been resolved in version 2.61.0-beta.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Aug 29, 2024

🎉 This issue has been resolved in version 2.61.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers released on @beta released
Projects
None yet
2 participants