Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate user exists for /user/<username>/card page #3933

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

zeucapua
Copy link
Contributor

Description

Implements a server side check that validates a user with the username in the URL exists, otherwise throws a 404 not found.

Related Tickets & Documents

Closes #3930

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Go to a DevCard page for a non-existent user (eg /user/zeucapua2/card)
  2. Ensure you are given a 404 page.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

john-cena-no-gif-by-buzzfeed

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit d479c65
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66bb8fe27420600008380014
😎 Deploy Preview https://deploy-preview-3933--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit d479c65
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66bb8fe23b0a060008066f4d
😎 Deploy Preview https://deploy-preview-3933--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua requested a review from a team August 12, 2024 23:59
@zeucapua zeucapua requested review from nickytonline and a team August 13, 2024 17:10
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zeucapua zeucapua added this pull request to the merge queue Aug 13, 2024
Merged via the queue into beta with commit 9976453 Aug 13, 2024
13 checks passed
@zeucapua zeucapua deleted the fix/devcard-validate-username branch August 13, 2024 21:41
open-sauced bot pushed a commit that referenced this pull request Aug 13, 2024
## [2.55.3-beta.1](v2.55.2...v2.55.3-beta.1) (2024-08-13)

### 🐛 Bug Fixes

* validate user exists for `/user/<username>/card` page ([#3933](#3933)) ([9976453](9976453))
open-sauced bot pushed a commit that referenced this pull request Aug 14, 2024
## [2.56.0](v2.55.2...v2.56.0) (2024-08-14)

### 🍕 Features

* now workspace can be generated from repo page via SBOM ([#3938](#3938)) ([e2bd019](e2bd019))

### 🐛 Bug Fixes

* fixed contributor insight contributor grid not loading paged data ([#3945](#3945)) ([1f645ed](1f645ed))
* now the Dev Card share buttons appear on all screen sizes ([#3941](#3941)) ([5fce569](5fce569))
* remove duplicate `DayRange` select ([#3939](#3939)) ([126d44f](126d44f))
* validate user exists for `/user/<username>/card` page ([#3933](#3933)) ([9976453](9976453))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: dev card page loads non-existent user
3 participants