-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: now workspace can be generated from repo page via SBOM #3938
Conversation
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dd33169
to
adb49b7
Compare
f53f133
to
deb35a3
Compare
Good call out. I can change it to a drop down button. I believe we have that component in the app already. If for some reason we don't have one, I can make the SBPM button a secondary variant. I'm going to finish the logged out flow for small screens first. It looks like we don't have that kind of component yet in the project from what I can tell. We have a select, but not exactly the right use case, so just going with the dark variant for that button for the moment. Once the other things are finished, I'll look into building a simlilar button to GitHub's multi merge button. I'm sure there's one in ShadCN. |
c803573
to
50ad98e
Compare
@bdougie I was going to say the same thing, two primary buttons is a bit too much. I'm ok with the secondary dark version to get it out the door, but the follow up should definitely add a dropdown button. However we do have the dropdown component, so I wonder if this would be just good enough for now? And we can work on a similar component but with a primary button + a down arrow as the dropdown trigger for a follow up |
Yeah I think that's the SingleSelect component? I can do a fast follow up on this using that. |
382cc2d
to
d36d796
Compare
#3942 will take care of this @bdougie @isabensusan |
I added a tooltip in 17e89c2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🎨
## [2.56.0-beta.1](v2.55.3-beta.1...v2.56.0-beta.1) (2024-08-13) ### 🍕 Features * now workspace can be generated from repo page via SBOM ([#3938](#3938)) ([e2bd019](e2bd019))
## [2.56.0](v2.55.2...v2.56.0) (2024-08-14) ### 🍕 Features * now workspace can be generated from repo page via SBOM ([#3938](#3938)) ([e2bd019](e2bd019)) ### 🐛 Bug Fixes * fixed contributor insight contributor grid not loading paged data ([#3945](#3945)) ([1f645ed](1f645ed)) * now the Dev Card share buttons appear on all screen sizes ([#3941](#3941)) ([5fce569](5fce569)) * remove duplicate `DayRange` select ([#3939](#3939)) ([126d44f](126d44f)) * validate user exists for `/user/<username>/card` page ([#3933](#3933)) ([9976453](9976453))
Description
Now you can generate a workspace via a repository page based on the repository's software bill of materials (SBOM).
Analytics also get sent to PostHog when someone clicks the Workspace from SBOM button.
Note that @jpmcb is working on SBOM for Go, but that does not block this PR. Once his stuff lands, it'll no longer report that a Go project isn't supported.
Until we have documentation, I'm linking directly to the https://www.cisa.gov/sbom page in the SBOM button tooltip.
Related Tickets & Documents
Closes #3842
Relates to https://github.com/open-sauced/api/issues/1027
Mobile & Desktop Screenshots/Recordings
The buttons are different colours now as mentioned in the comments below. Dropping a screenshot here as the video isn't up to date.
SBOM.Workspace.Video.mp4
Steps to QA
SBOM for some-org/some-repo
, e.g.SBOM for microsoft/playwright
.Note that sometimes it can take a while for the SBOM API call to complete.
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?