feat: use SplitButton for repo page Add Workspace buttons
#4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itButton action type
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
requested changes
Aug 28, 2024
|
It shouldn't shift now; aligned the dropdown menu to "end", bringing it more towards the center of the page
|
brandonroberts
approved these changes
Aug 29, 2024
nickytonline
requested changes
Aug 29, 2024
|
Looks like under the hood, radix uses the Context: radix-ui/primitives#1100 |
nickytonline
approved these changes
Aug 30, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
## [2.62.0-beta.1](v2.61.0...v2.62.0-beta.1) (2024-08-30) ### 🍕 Features * use `SplitButton` for repo page Add Workspace buttons ([#4062](#4062)) ([6cf13e6](6cf13e6))
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
## [2.62.0](v2.61.0...v2.62.0) (2024-09-10) ### 🍕 Features * use `SplitButton` for repo page Add Workspace buttons ([#4062](#4062)) ([6cf13e6](6cf13e6)) ### 🐛 Bug Fixes * correct no insights message on contributor insights ([#4090](#4090)) ([49dfa03](49dfa03)) * fixed dropdown styling ([#4077](#4077)) ([4fa8b7f](4fa8b7f)) * use custom error component with Sentry error reporting for 500s ([#4078](#4078)) ([c3fd10e](c3fd10e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
SplitButtoncomponent to combine the 'Add to Workspace' and 'Create Workspace from SBOM' buttons on desktop. Adds a new optional 'icon' prop toSplitButton.Note: this is only for the desktop view. On mobile we are using the
Drawercomponent which requires its own trigger button, so it can't be separated to an external trigger.Related Tickets & Documents
Closes #3942
Mobile & Desktop Screenshots/Recordings
Arc.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?