Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a tags instead of link tags #4158

Merged

Conversation

Bashamega
Copy link
Contributor

Description

Fixed the bug by using a tags instead of link tags

Related Tickets & Documents

Fixes #4108

Mobile & Desktop Screenshots/Recordings

2024-10-10.11-32-00.mp4

Steps to QA

…d of link tags

fixed the bug by using a tags instead of link tags

fix open-sauced#4108
Copy link

netlify bot commented Oct 10, 2024

👷 Deploy request for oss-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4080973

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 4080973
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/670791fced3c6e0008c0f205
😎 Deploy Preview https://deploy-preview-4158--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bashamega!

@nickytonline nickytonline added this pull request to the merge queue Oct 10, 2024
Merged via the queue into open-sauced:beta with commit 7b48770 Oct 10, 2024
11 checks passed
open-sauced bot pushed a commit that referenced this pull request Oct 10, 2024
## [2.64.0-beta.2](v2.64.0-beta.1...v2.64.0-beta.2) (2024-10-10)

### 🐛 Bug Fixes

* use a tags instead of link tags ([#4158](#4158)) ([7b48770](7b48770))
@Bashamega Bashamega deleted the fix/contributor-profile-header branch October 10, 2024 16:13
open-sauced bot pushed a commit that referenced this pull request Oct 22, 2024
## [2.64.0](v2.63.0...v2.64.0) (2024-10-22)

### 🍕 Features

* download `ContributorsTable` data as JSON/CSV ([#4151](#4151)) ([d87b37e](d87b37e))
* removed developer pack form from user settings page ([#4173](#4173)) ([da975d7](da975d7))
* removed payments and limits ([#4171](#4171)) ([898d889](898d889))

### 🐛 Bug Fixes

* a11y rule "iframe-has-title" fails with a warning. ([#4162](#4162)) ([f15764a](f15764a))
* a11y rule "img-redundant-alt" fails with a warning ([#4176](#4176)) ([cc9cdf0](cc9cdf0))
* a11y rule "no-noninteractive-element-interactions" ([#4163](#4163)) ([4d26abc](4d26abc))
* fixed changing workspaces visibility regression ([#4172](#4172)) ([ee12474](ee12474))
* Make the "create workspace" option more obvious ([#4177](#4177)) ([9d8ae39](9d8ae39))
* removed unused code ([#4178](#4178)) ([d6fff39](d6fff39))
* resolve a11y warnings for role-supports-aria-props rule ([#4174](#4174)) ([95e2099](95e2099))
* throw errors on insight creation failure ([#4145](#4145)) ([e3f8db3](e3f8db3))
* use a tags instead of link tags ([#4158](#4158)) ([7b48770](7b48770))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: loading dev card page from the user profile crashes
3 participants