-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add keyboard support to CardHorizontalBarChart and InfoTooltip #4165
fix: Add keyboard support to CardHorizontalBarChart and InfoTooltip #4165
Conversation
❌ Deploy Preview for oss-insights failed. Why did it fail? →
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Taylor <nick@nickyt.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @Firdous2307. Just a couple other things to remove and this is good to go. Thanks for your patience!
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Taylor <nick@nickyt.co>
Co-authored-by: Nick Taylor <nick@nickyt.co>
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
Hi @Firdous2307, just seeing if you're blocked on anything. No rush on this, just checking in. |
@nickytonline Everything is good, I just took a little break, thanks for checking in. |
@nickytonline I mistakenly closed the main repository, thinking the changes were already merged. Apologies for the inconvenience. I'll redo the necessary steps, which should be fewer now since we’ve already addressed the main point. |
Description
This PR fixes accessibility issues in the CardHorizontalBarChart and InfoTooltip components. It addresses the
jsx-a11y/mouse-events-have-key-events
warnings and improves keyboard navigation support.Related Tickets & Documents
Fixes #4133
Mobile & Desktop Screenshots/Recordings
N/A (No visual changes, only accessibility improvements)
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?