Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed changing workspaces visibility regression #4172

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Oct 17, 2024

Description

Fixes a regression introduced in #4171

Related Tickets & Documents

Relates to #4171

Mobile & Desktop Screenshots/Recordings

CleanShot 2024-10-17 at 16 30 27

Steps to QA

  1. Log in
  2. Navigate to a workspace you own
  3. Edit the workspace settings
  4. Scroll to the visibility section
  5. Click the Set to private button
  6. Click the yes, set to private button in the modal
  7. Do the same thing again, but to set it to private.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 02f9f13
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/671173d175475d00085c2252
😎 Deploy Preview https://deploy-preview-4172--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 02f9f13
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/671173d1dd96bf000860058f
😎 Deploy Preview https://deploy-preview-4172--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team October 17, 2024 20:33
@nickytonline nickytonline added this pull request to the merge queue Oct 17, 2024
Merged via the queue into beta with commit ee12474 Oct 17, 2024
25 checks passed
@nickytonline nickytonline deleted the nickytonline/workspace-visibilty-fix branch October 17, 2024 20:43
open-sauced bot pushed a commit that referenced this pull request Oct 17, 2024
## [2.64.0-beta.6](v2.64.0-beta.5...v2.64.0-beta.6) (2024-10-17)

### 🐛 Bug Fixes

* fixed changing workspaces visibility regression ([#4172](#4172)) ([ee12474](ee12474))
open-sauced bot pushed a commit that referenced this pull request Oct 22, 2024
## [2.64.0](v2.63.0...v2.64.0) (2024-10-22)

### 🍕 Features

* download `ContributorsTable` data as JSON/CSV ([#4151](#4151)) ([d87b37e](d87b37e))
* removed developer pack form from user settings page ([#4173](#4173)) ([da975d7](da975d7))
* removed payments and limits ([#4171](#4171)) ([898d889](898d889))

### 🐛 Bug Fixes

* a11y rule "iframe-has-title" fails with a warning. ([#4162](#4162)) ([f15764a](f15764a))
* a11y rule "img-redundant-alt" fails with a warning ([#4176](#4176)) ([cc9cdf0](cc9cdf0))
* a11y rule "no-noninteractive-element-interactions" ([#4163](#4163)) ([4d26abc](4d26abc))
* fixed changing workspaces visibility regression ([#4172](#4172)) ([ee12474](ee12474))
* Make the "create workspace" option more obvious ([#4177](#4177)) ([9d8ae39](9d8ae39))
* removed unused code ([#4178](#4178)) ([d6fff39](d6fff39))
* resolve a11y warnings for role-supports-aria-props rule ([#4174](#4174)) ([95e2099](95e2099))
* throw errors on insight creation failure ([#4145](#4145)) ([e3f8db3](e3f8db3))
* use a tags instead of link tags ([#4158](#4158)) ([7b48770](7b48770))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants