Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Bug: Broken search #523

Closed
1 of 2 tasks
bdougie opened this issue Apr 13, 2024 · 11 comments · Fixed by #524
Closed
1 of 2 tasks

Bug: Broken search #523

bdougie opened this issue Apr 13, 2024 · 11 comments · Fixed by #524
Assignees
Labels

Comments

@bdougie
Copy link
Member

bdougie commented Apr 13, 2024

Describe the bug

I broke search in my last release. It is failing on starCount, should be item.star_count

Screen Shot 2024-04-13 at 11 02 44 AM

Steps to reproduce

Search and hitenter

Do you have any images or screen captures?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added the 🐛 bug Something isn't working label Apr 13, 2024
@furqan-abid
Copy link
Contributor

.take

Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

@furqan-abid
Copy link
Contributor

before

Screen.Recording.2024-04-14.at.6.26.34.PM.mov

@furqan-abid
Copy link
Contributor

after

Screen.Recording.2024-04-14.at.6.15.35.PM.mov

blank screen issue fixed

@bdougie
Copy link
Member Author

bdougie commented Apr 14, 2024

@furqan-abid your PR is not really fixing the the issue. I had two approaches I was considering

  1. Remove Search all together
  2. Search from the api.opensauced.pizza repos endpoint directly and remove the supabase hook.

@furqan-abid
Copy link
Contributor

@bdougie Thanks for your input. could I temporarily comment it out if it's not essential?

@bdougie
Copy link
Member Author

bdougie commented Apr 14, 2024

No need to comment. Code is stored in git history. You just remove all of the search input context.

@furqan-abid
Copy link
Contributor

Got it, I'll remove the search input

@furqan-abid
Copy link
Contributor

@bdougie search bar removed!
Screenshot 2024-04-14 at 9 57 45 PM

Copy link

🎉 This issue has been resolved in version 2.37.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 2.37.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants