Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pizza generate codeowners needs to support the --tty-disable flag #154

Closed
jpmcb opened this issue Sep 6, 2024 · 2 comments · Fixed by #159
Closed

Bug: pizza generate codeowners needs to support the --tty-disable flag #154

jpmcb opened this issue Sep 6, 2024 · 2 comments · Fixed by #159

Comments

@jpmcb
Copy link
Member

jpmcb commented Sep 6, 2024

Describe the bug

The codeowners generation flow now has interactive bits that could break CI/CD:

❯ ./build/pizza generate codeowners .
Config path loading from -c flag ~/.sauced.yaml
Finished processing commits for: /Users/jpmcb/workspace/opensauced/pizza-cli
Finished generating file: /Users/jpmcb/workspace/opensauced/pizza-cli/CODEOWNERS
Do you want to add these codeowners to an OpenSauced Contributor Insight? (y/n):

Adding the --tty-disable flag doesn't do anything and this wasn't implemented in #141

Providing the --tty-disable flag should ignore the interactive user flow:

❯ ./build/pizza generate codeowners . --tty-disable
Config path loading from -c flag ~/.sauced.yaml
Iterating commits for repo: /Users/jpmcb/workspace/opensauced/pizza-cli
Finished processing commits for: /Users/jpmcb/workspace/opensauced/pizza-cli
Finished generating file: /Users/jpmcb/workspace/opensauced/pizza-cli/CODEOWNERS

❯

Steps to reproduce

Run pizza generate codeowners on a repo with the --tty-disable flag and notice it still goes into interactive mode which could break CI/CD systems.

Copy link
Contributor

open-sauced bot commented Sep 6, 2024

🎉 This issue has been resolved in version 1.3.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Sep 11, 2024

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants