Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/prometheusreceiver] identify telemetry scraped by the prometheus receiver #13615

Closed
mwear opened this issue Aug 24, 2022 · 4 comments
Closed
Labels
enhancement New feature or request priority:p2 Medium receiver/prometheus Prometheus receiver

Comments

@mwear
Copy link
Member

mwear commented Aug 24, 2022

Is your feature request related to a problem? Please describe.
I would like to be able to tell which metrics are scraped by the prometheus receiver.

Describe the solution you'd like
Most receivers set the scope name to the receiver name (e.g. otelcol/postgresqlreceiver). The most straightforward solution would be to set the scope name to otelcol/prometheusreceiver.

Describe alternatives you've considered
If scope.name is reserved for other use with the prometheus receiver, we could use a different scope attribute, or even a resource attribute.

Additional context

@evan-bradley evan-bradley added enhancement New feature or request priority:p2 Medium receiver/prometheus Prometheus receiver labels Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Pinging code owners: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Apr 17, 2023

See #20902 as duplicate.

@paologallinaharbur
Copy link
Member

I think we can close this since this #20903 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:p2 Medium receiver/prometheus Prometheus receiver
Projects
None yet
Development

No branches or pull requests

5 participants