Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mysql] Add database resource attributes #16063

Closed
portertech opened this issue Nov 3, 2022 · 5 comments
Closed

[receiver/mysql] Add database resource attributes #16063

portertech opened this issue Nov 3, 2022 · 5 comments

Comments

@portertech
Copy link
Contributor

portertech commented Nov 3, 2022

Component(s)

receiver/mysql

Is your feature request related to a problem? Please describe.

Need human-friendly identifiers of the database to be used for filtering etc.

Describe the solution you'd like

Considering the following attributes at this time:

db.cluster.name

Name of the database cluster (configured manually by the user), it serves as a human-friendly database identifier. Tracing uses db.name, but it has a caveat: “In some SQL databases, the database name to be used is called “schema name”. In case there are multiple layers that could be considered for database name (e.g. Oracle instance name and schema name), the database name to be used is the more specific layer (e.g. Oracle schema name)“.

db.cluster.address

Network address used by end users to connect to the database. There can be several addresses used to connect to a single database and they may be different than the address used to collect metrics. Tracing has net.peer.addr, but this attribute doesn’t make much sense in the metrics context.

db.cluster.port

Network port used by end users to connect to the database. Tracing has net.peer.port, but this attribute doesn’t make much sense in the metrics context.

Describe alternatives you've considered

No response

Additional context

Add database resource specification #2916
[receiver/mysql] add support for more metrics #14138

@portertech portertech added enhancement New feature or request needs triage New item requiring triage labels Nov 3, 2022
@portertech portertech changed the title Add mysql receiver database resource attributes [receiver/mysql] Add database resource attributes Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@fatsheep9146 fatsheep9146 removed the needs triage New item requiring triage label Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 3, 2023
@atoulme
Copy link
Contributor

atoulme commented Jan 3, 2023

Please try to get this on the agenda of the specification SIG. Open an issue on opentelemetry-specification with your rationale and come to a SIG meeting to get this under review.

@github-actions github-actions bot removed the Stale label Jan 8, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 10, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants