-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing environment for sentry exporter #18694
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This makes sense, but I think we probably want to selectively grab the environment based on the incoming data, and not do it with a blanket collector config. FYI we also have: getsentry/sentry#40712 |
Well, for my projects, each project has their own separate config for each environment, so I only need to set the dsn value and the env, and this would work. I'm not sure if this is the best approach for other projects |
I guess it's fair to just ship this for now to unblock you, but we should add documentation that this applies to every single event. |
Hi, I'm reopening this since I just found out that because sentryexporter is using I need to actually attach the environment value on the transaction.Environment = environment any idea of how I can implement this with the same approach (using config)? |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
exporter/sentry
Is your feature request related to a problem? Please describe.
Hi, I'd like to be able to pass an environment for the sentry exporter as it is currently not supported, for easier sentry filtering
Describe the solution you'd like
Describe alternatives you've considered
No response
Additional context
I can create a PR for this
The text was updated successfully, but these errors were encountered: