Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB exporter/receiver do not sum/decompose histogram bucket counts #19453

Closed
jacobmarble opened this issue Mar 10, 2023 · 0 comments · Fixed by #19454
Closed

InfluxDB exporter/receiver do not sum/decompose histogram bucket counts #19453

jacobmarble opened this issue Mar 10, 2023 · 0 comments · Fixed by #19454
Labels
bug Something isn't working needs triage New item requiring triage

Comments

@jacobmarble
Copy link
Contributor

Component(s)

exporter/influxdb, receiver/influxdb

What happened?

Description

The InfluxDB/otel conversion library assumed that OpenTelemetry histogram buckets are cumulative, like Prometheus histogram buckets. The result is that the bucket counts are always incorrect after conversion.

Originally reported here: influxdata/influxdb-observability#60

Steps to Reproduce

Either:

  • Configure otelcol-contrib to export InfluxDB/Telegraf metrics with Prometheus v1 or v2 schema
  • Receive an OpenTelemetry histogram via OTLP

Or:

  • Configure otelcol-contrib to receive InfluxDB/Telegraf metrics with Prometheus v1 or v2 schema
  • Receive a histogram from Telegraf via line protocol

Expected Result

This otel histogram:

0.05: 24054
0.1: 9390
0.2: 66948
0.5: 28997
1: 4599
inf: 10332

Yields this line protocol (schema is Telegraf Prometheus v1 in the example):

count=144320,sum=53423,0.05=24054,0.1=33444,0.2=100392,0.5=129389,1=133988

And visa-versa.

Actual Result

This otel histogram:

0.05: 24054
0.1: 9390
0.2: 66948
0.5: 28997
1: 4599
inf: 10332

Yields this line protocol (schema is Telegraf Prometheus v1 in the example):

count=144320,sum=53423,0.05=24054,0.1=9390,0.2=66948,0.5=28997,1=4599

And this line protocol:

count=144320,sum=53423,0.05=24054,0.1=33444,0.2=100392,0.5=129389,1=133988

Yields this otel histogram:

0.05: 24054
0.1: 33444
0.2: 100392
0.5: 129389
1: 133988
inf: 144320

Collector version

v0.73.0

Environment information

Environment

OS: MacOS 13.2 (and surely every OS)
Compiler(if manually compiled): go 1.19.5 (and surely every compiler)

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage
Projects
None yet
1 participant