Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity around connector/spanmetrics dimensions_cache_size #23004

Closed
danelson opened this issue Jun 1, 2023 · 4 comments
Closed

Clarity around connector/spanmetrics dimensions_cache_size #23004

danelson opened this issue Jun 1, 2023 · 4 comments
Labels
connector/spanmetrics needs triage New item requiring triage

Comments

@danelson
Copy link
Contributor

danelson commented Jun 1, 2023

Component(s)

connector/spanmetrics

Describe the issue you're reporting

The spanmetrics connector exposes a dimensions_cache_size option. I am curious about the following:

I also think that the README should be updated to address these questions.

@danelson danelson added the needs triage New item requiring triage label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@danelson
Copy link
Contributor Author

danelson commented Jun 6, 2023

I was under the working assumption that dimensions_cache_size was going to prevent dimensions from being exported but that doesn't appear to be the case. Is the setting only affecting performance and not functionality?

@kovrus
Copy link
Member

kovrus commented Jun 6, 2023

Is the setting only affecting performance and not functionality?

yes, it is used only to improve performance.

What is the behavior when dimensions_cache_size is reached?

Old items in a cache will be invalidated

@danelson
Copy link
Contributor Author

danelson commented Jun 6, 2023

@kovrus thank you. I was worried that having very high dimensionality was going to result in me missing metrics. I have what I need from this so I am closing.

@danelson danelson closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants