Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gendependabot causes removal of components when adding a new component #24363

Closed
adrielp opened this issue Jul 18, 2023 · 2 comments
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists needs triage New item requiring triage

Comments

@adrielp
Copy link
Contributor

adrielp commented Jul 18, 2023

Component(s)

No response

What happened?

Description

I was adding a new receiver component and my pr showed up as removing the ssh receiver from the dependebot.yaml after running make gendependabot. The question as to why was brought up in this pull request. This command is something I have to run to be able to pass all the checks and merge the PR. So I investigated why.

Quote from my original findings:

Looking at this more, it looks to have been removed as a sideeffect of having placed a limit on make gendependabot
As I understand, it's going to iterate through all the mod dirs, and it's going to stop appending to the generate file once you've got 220 entries. Looks like the addition of this component is bumping the other component out of place.
The build and test workflow is going to run make gendependabot every time and error out if the diff is different. That's why the checks pass with the removal of that component, but don't pass if I haven't run the command & committed the change.

I couldn't find any specific reference in GitHub's docs about a limit to 220 entries though. We should be able to add all components managed by dependabot. I do wonder if Renovate has a similar limit.

Steps to Reproduce

  • add a new component that being with a letter earlier in the alphabet
  • run make gendependabot
  • look at the diff

Expected Result

  • does not remove a component from the dependabot.yaml on regeneration

Actual Result

  • removes a component from the dependabot.yaml on regeneration

Collector version

v0.81.0

Environment information

This is a make issue

OpenTelemetry Collector configuration

n/a

Log output

n/a

Additional context

See this comment: #23225 (comment)

@atoulme
Copy link
Contributor

atoulme commented Jul 18, 2023

Here is why this is happening: #19410

@mx-psi
Copy link
Member

mx-psi commented Jul 18, 2023

Closing this as a duplicate of #19410

@mx-psi mx-psi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@mx-psi mx-psi added the duplicate This issue or pull request already exists label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

3 participants