Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] receiver/redis works for KeyDB also? #29457

Closed
ceevaaa opened this issue Nov 23, 2023 · 6 comments
Closed

[question] receiver/redis works for KeyDB also? #29457

ceevaaa opened this issue Nov 23, 2023 · 6 comments
Labels
question Further information is requested receiver/redis Redis related issues

Comments

@ceevaaa
Copy link

ceevaaa commented Nov 23, 2023

Component(s)

receiver/redis

Question

Can the Redis receiver also fetch metrics for KeyDB, as KeyDB is a fork of Redis and uses the same "INFO" command ?

Answer

I tested it. And voila, it works.
So my question is, was this intentional/planned OR just a happy coincidental usecase ?

Regards

Collector version

v0.89.0

@ceevaaa ceevaaa added bug Something isn't working needs triage New item requiring triage labels Nov 23, 2023
@github-actions github-actions bot added the receiver/redis Redis related issues label Nov 23, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ceevaaa
Copy link
Author

ceevaaa commented Nov 23, 2023

/label -bug

@crobert-1 crobert-1 added question Further information is requested and removed bug Something isn't working needs triage New item requiring triage labels Nov 23, 2023
@crobert-1
Copy link
Member

I did a quick search and didn't see any reference to KeyDB in the history of this component, so my guess would be that it was not planned. I'll leave it open for the code owners though in case they want to provide more information here.

@hughesjj
Copy link
Contributor

Hey, it's not officially planned nor supported, but of course we won't stop you for using it for keydb if it works for you.

If you're worried about ongoing support, we can always discuss making a bespoke keydb receiver.

@ceevaaa
Copy link
Author

ceevaaa commented Nov 28, 2023

Hey @hughesjj thanks for replying.

I think it works for me right now, so no worries there.
About the custom receiver for KeyDB itself, I am not sure. Maybe the community might be able to answer this better.

Cheers!

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Closing as complete.

@atoulme atoulme closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested receiver/redis Redis related issues
Projects
None yet
Development

No branches or pull requests

4 participants