Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/f5cloud] TestLoadConfig failed when new config is introduced to otlphttpexporter #30703

Closed
songy23 opened this issue Jan 22, 2024 · 1 comment · Fixed by #30759
Closed

[exporter/f5cloud] TestLoadConfig failed when new config is introduced to otlphttpexporter #30703

songy23 opened this issue Jan 22, 2024 · 1 comment · Fixed by #30759
Assignees
@songy23
Labels
exporter/f5cloud F5 exporter

Comments

@songy23
Copy link
Member

songy23 commented Jan 22, 2024

Component(s)

exporter/f5cloud

Describe the issue you're reporting

opentelemetry-collector-contrib/exporter/f5cloudexporter/config_test.go

Line 20 in 82484a2

otlphttp "go.opentelemetry.io/collector/exporter/otlphttpexporter"

This test failed when a new config was added to otlphttpexporter in core (open-telemetry/opentelemetry-collector#9276). Adding a new config with default shouldn't be a breaking change, and the test should be tolerant with such changes.
@songy23 songy23 added the needs triage New item requiring triage label Jan 22, 2024
@github-actions github-actions bot added the exporter/f5cloud F5 exporter label Jan 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 mentioned this issue Jan 22, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@songy23 songy23 mentioned this issue Jan 24, 2024
Merged
@songy23 songy23 self-assigned this Jan 24, 2024
@songy23 songy23 removed the needs triage New item requiring triage label Jan 24, 2024
TylerHelmuth pushed a commit that referenced this issue Jan 24, 2024
@songy23
[chore][exporter/f5cloud] Fix TestLoadConfig w/ using factory default…
409ecbf 
… configs (#30759)

Fixes
#30703.

This changes the test to create a otlphttpCfg from factory default, so
that the test doesn't fail when new fields are introduced to otlphttp
default config.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@songy23 @cparkins
[chore][exporter/f5cloud] Fix TestLoadConfig w/ using factory default…
3a4138c 
… configs (open-telemetry#30759)

Fixes
open-telemetry#30703.

This changes the test to create a otlphttpCfg from factory default, so
that the test doesn't fail when new fields are introduced to otlphttp
default config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songy23 songy23

Labels
exporter/f5cloud F5 exporter
Projects
None yet
Milestone
No milestone
1 participant
@songy23