Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cumulativetodeltaprocessor] Convert non-monotonic sums #5876

Closed
alanwest opened this issue Oct 22, 2021 · 2 comments
Closed

[cumulativetodeltaprocessor] Convert non-monotonic sums #5876

alanwest opened this issue Oct 22, 2021 · 2 comments
Labels
processor/cumulativetodelta Cumulative To Delta processor

Comments

@alanwest
Copy link
Member

This is more of a question of whether the cumulative to delta processor should allow for converting non-monotonic sums.

#4444 originally had a setting for converting non-monotonic cumulative sums (defaulted to only converting monotonic metrics). Systems supporting delta temporality usually treat non-monotonic sums as gauges, so the setting was removed.

In light of #4444 (comment), a question remains of whether this setting is in fact useful.
@alanwest alanwest mentioned this issue Oct 22, 2021
Merged
@mx-psi mx-psi added the processor/cumulativetodelta Cumulative To Delta processor label Jul 21, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @TylerHelmuth

@TylerHelmuth
Copy link
Member

At the moment there are no plans to support converting non-monotonic cumulative sums.

povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@junhaoyu-aws @bogdandrutu
httpprovider for Collector: load configuration from config files in H…
a515ff9 
…TTP servers (#5876)

* httpprovider to upstream

* no slashes in the prefix check

* use httptest package to do unit tests; then add one more testcase TestValidateProviderScheme

* added error checks for http.ResponseWriter.Write()

* Fixed bug of variable shadows, then replace old io/ioutil package with io and os

* update the old name ConfigMapProvider

* Remove unnecessary interface of httpClient

* README fixed with

* Removed NewTestProvider/NewTestInvalidProvider/NewTestNonExistProvider and replace with New; Minor tweaks for Empty URI and Non-exist cases; Added one more test for shutdowned server

* Simplified unit tests for TestNonExistent and TestRetrieveFromShutdownServer

* Update CHANGELOG.md

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
processor/cumulativetodelta Cumulative To Delta processor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanwest @mx-psi @TylerHelmuth