Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI check failure is difficult to troubleshoot #7302

Closed
codeboten opened this issue Jan 21, 2022 · 5 comments
Closed

MSI check failure is difficult to troubleshoot #7302

codeboten opened this issue Jan 21, 2022 · 5 comments
Labels
ci-cd CI, CD, testing, build issues packaging Packaging (DEB,RPM,MSI...) related issues Stale

Comments

@codeboten
Copy link
Contributor

Currently, build failures for the MSI check don't give developers any idea as to what is causing the problem. See example: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/4888218835?check_suite_focus=true

The failure was caused by an error on startup from the collector, this information would have greatly helped troubleshoot the problem. My ask of this issue is to somehow collect more information from this step in the build, if at all possible. At the very least msiexec could be called with logging enabled.

@codeboten codeboten added the ci-cd CI, CD, testing, build issues label Jan 21, 2022
@mx-psi mx-psi added the packaging Packaging (DEB,RPM,MSI...) related issues label Jan 24, 2022
@jpkrohling
Copy link
Member

Should the packaging steps be removed from the CI of this repository? We do not produce MSI/deb/rpm as part of this anymore.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@codeboten
Copy link
Contributor Author

@jpkrohling if i recall correctly, the problem was caused by a change in the core collector's parsing of command line args on windows. The problem that should really be addressed is that the core collector repo doesn't run tests that would show the problem before it is released. There is an issue to track adding better windows testing in the core: open-telemetry/opentelemetry-collector#6455

I don't know if we need this issue anymore, something tells me there should be at least some sanity checks for the contrib components on windows.

@github-actions github-actions bot removed the Stale label Apr 19, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@jpkrohling
Copy link
Member

Alright, I'm closing this then. We can reopen if we still have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues packaging Packaging (DEB,RPM,MSI...) related issues Stale
Projects
None yet
Development

No branches or pull requests

3 participants