-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSI check failure is difficult to troubleshoot #7302
Comments
Should the packaging steps be removed from the CI of this repository? We do not produce MSI/deb/rpm as part of this anymore. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
@jpkrohling if i recall correctly, the problem was caused by a change in the core collector's parsing of command line args on windows. The problem that should really be addressed is that the core collector repo doesn't run tests that would show the problem before it is released. There is an issue to track adding better windows testing in the core: open-telemetry/opentelemetry-collector#6455 I don't know if we need this issue anymore, something tells me there should be at least some sanity checks for the contrib components on windows. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
Alright, I'm closing this then. We can reopen if we still have problems. |
Currently, build failures for the MSI check don't give developers any idea as to what is causing the problem. See example: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/4888218835?check_suite_focus=true
The failure was caused by an error on startup from the collector, this information would have greatly helped troubleshoot the problem. My ask of this issue is to somehow collect more information from this step in the build, if at all possible. At the very least msiexec could be called with logging enabled.
The text was updated successfully, but these errors were encountered: