diff --git a/.chloggen/awss3-checkapi.yaml b/.chloggen/awss3-checkapi.yaml new file mode 100644 index 000000000000..9494b6c2d417 --- /dev/null +++ b/.chloggen/awss3-checkapi.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: breaking + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: awss3exporter + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Do not export the function `NewMarshaler` + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [26304] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [api] diff --git a/cmd/checkapi/allowlist.txt b/cmd/checkapi/allowlist.txt index 53c927380f3e..b7be8a3843b1 100644 --- a/cmd/checkapi/allowlist.txt +++ b/cmd/checkapi/allowlist.txt @@ -2,7 +2,6 @@ connector/servicegraphconnector exporter/alibabacloudlogserviceexporter exporter/awscloudwatchlogsexporter exporter/awskinesisexporter -exporter/awss3exporter exporter/azuremonitorexporter exporter/coralogixexporter exporter/datasetexporter diff --git a/exporter/awss3exporter/exporter.go b/exporter/awss3exporter/exporter.go index 36ff0c8245b8..6f86d185e19a 100644 --- a/exporter/awss3exporter/exporter.go +++ b/exporter/awss3exporter/exporter.go @@ -31,7 +31,7 @@ func newS3Exporter(config *Config, logger := params.Logger - m, err := NewMarshaler(config.MarshalerName, logger) + m, err := newMarshaler(config.MarshalerName, logger) if err != nil { return nil, errors.New("unknown marshaler") } diff --git a/exporter/awss3exporter/exporter_test.go b/exporter/awss3exporter/exporter_test.go index 01c8cc74ca07..8c06efb5acf4 100644 --- a/exporter/awss3exporter/exporter_test.go +++ b/exporter/awss3exporter/exporter_test.go @@ -31,7 +31,7 @@ func getTestLogs(tb testing.TB) plog.Logs { } func getLogExporter(t *testing.T) *s3Exporter { - marshaler, _ := NewMarshaler("otlp_json", zap.NewNop()) + marshaler, _ := newMarshaler("otlp_json", zap.NewNop()) exporter := &s3Exporter{ config: createDefaultConfig().(*Config), dataWriter: &TestWriter{t}, diff --git a/exporter/awss3exporter/marshaler.go b/exporter/awss3exporter/marshaler.go index 686ca49d6dfe..30d18bfd3b86 100644 --- a/exporter/awss3exporter/marshaler.go +++ b/exporter/awss3exporter/marshaler.go @@ -23,7 +23,7 @@ var ( ErrUnknownMarshaler = errors.New("unknown marshaler") ) -func NewMarshaler(mType MarshalerType, logger *zap.Logger) (marshaler, error) { +func newMarshaler(mType MarshalerType, logger *zap.Logger) (marshaler, error) { marshaler := &s3Marshaler{logger: logger} switch mType { case OtlpJSON: diff --git a/exporter/awss3exporter/marshaler_test.go b/exporter/awss3exporter/marshaler_test.go index 791a31bc8903..d0ede1990099 100644 --- a/exporter/awss3exporter/marshaler_test.go +++ b/exporter/awss3exporter/marshaler_test.go @@ -13,19 +13,19 @@ import ( func TestMarshaler(t *testing.T) { { - m, err := NewMarshaler("otlp_json", zap.NewNop()) + m, err := newMarshaler("otlp_json", zap.NewNop()) assert.NoError(t, err) require.NotNil(t, m) assert.Equal(t, m.format(), "json") } { - m, err := NewMarshaler("sumo_ic", zap.NewNop()) + m, err := newMarshaler("sumo_ic", zap.NewNop()) assert.NoError(t, err) require.NotNil(t, m) assert.Equal(t, m.format(), "json.gz") } { - m, err := NewMarshaler("unknown", zap.NewNop()) + m, err := newMarshaler("unknown", zap.NewNop()) assert.Error(t, err) require.Nil(t, m) }