Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current workflow allows partial releases when CI fails for a single distro #571

Open
mx-psi opened this issue Jun 4, 2024 · 1 comment

Comments

@mx-psi
Copy link
Member

mx-psi commented Jun 4, 2024

During the v0.102.0 we ran into an issue with #560 that caused the release of core and contrib distros to fail (see #560 (comment)).

In the release, I cancelled the k8s distro release https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/9366469958/job/25784146751. This would have passed, since we don't support this distro on Windows.

I cancelled it since we use the same tag for all distros and it would have led to an awkward state where we release different distros from different versions of the same tag, but I was lucky: had I not been paying attention, we would have had to have two partial releases.

Is this a problem? What should we do to address this if so?

@mx-psi mx-psi changed the title Current workflow allows partial releases Current workflow allows partial releases when CI fails for a single distro Jun 4, 2024
@TylerHelmuth
Copy link
Member

We talked a little about this topic in #429. In my opinion we should be releasing each distro with its own tag push, instead of releasing all distros based on the same tag push.

This allows each distro to be released completely independently. In your situation the k8s distro would have been allowed to finish its release without issues while you worked on fixing Contrib and Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants