Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standard way to create a map of metric identity #4248

Closed
alanwest opened this issue Oct 22, 2021 · 0 comments
Closed

Create a standard way to create a map of metric identity #4248

alanwest opened this issue Oct 22, 2021 · 0 comments
Labels

Comments

@alanwest
Copy link
Member

This was proposed by @jmacd in the context of the cumulative to delta processor from the contrib repo. open-telemetry/opentelemetry-collector-contrib#4444 (review)

There ought to be a standard way to create a map of metric identity, because more than one processor is going to use such a thing. The OTel-Go SDK has such a thing, but it's not perfectly simple to adapt. The tracking entry here could be replaced by a struct that is usable as a map key w/o the Write() mechanism, but I wouldn't hold up this PR because of it. The collector should support something like the OTel-Go attribute.Distinct type that applies to model/pdata types so that code like this can easily create a map key based on resource, instrumentation library, name, unit and attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant