Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loggingexporter] detailed verbosity level should also log exemplars #7912

Closed
matej-g opened this issue Jun 16, 2023 · 7 comments
Closed

[loggingexporter] detailed verbosity level should also log exemplars #7912

matej-g opened this issue Jun 16, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request exporter/logging Logging exporter related issues priority:p2 Medium

Comments

@matej-g
Copy link
Contributor

matej-g commented Jun 16, 2023

Is your feature request related to a problem? Please describe.
When doing various testing / debugging with the detailed verbosity, it would be nice to see exemplars attached to a metric data points.

Describe the solution you'd like
Logging exporter, when configured with detailed verbosity, logs exemplar information.

Describe alternatives you've considered
No alternative.

Additional context
I'd be happy to put in the work to add this feature.

@mx-psi mx-psi added enhancement New feature or request priority:p2 Medium spec:metrics exporter/logging Logging exporter related issues labels Jun 16, 2023
@mx-psi
Copy link
Member

mx-psi commented Jun 16, 2023

Makes sense to me to add this :)

@shivanshuraj1333
Copy link
Member

I'd like to work on this, Can I get it assigned to me? Thanks!

@mx-psi
Copy link
Member

mx-psi commented Jun 20, 2023

@shivanshu1333, I believe @matej-g intended to work on this, I will leave this up to you two to discuss

@matej-g
Copy link
Contributor Author

matej-g commented Jun 20, 2023

Feel free to go for it @shivanshu1333, I'd be happy to assist or review if any help will be needed 🙂

@oliver-zhang
Copy link

@shivanshu1333 Are you starting on this ?

@shivanshuraj1333
Copy link
Member

Hi @oliver-zhang I've done some work would try to open a PR this weekend.

@matej-g
Copy link
Contributor Author

matej-g commented Jul 28, 2023

Hey folks 👋, I opened #8142 in order to try and speed up the process a bit, I hope that's fine. Reviews are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/logging Logging exporter related issues priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

4 participants