From 3fa337aa43a0fec7023cca6d6d42ab459a576b95 Mon Sep 17 00:00:00 2001 From: Tianlin Zhao Date: Thu, 13 Aug 2020 14:46:35 -0400 Subject: [PATCH] resolving issues --- api/test/trace/noop_test.cc | 43 +++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/api/test/trace/noop_test.cc b/api/test/trace/noop_test.cc index cf2005cae1..814b372312 100644 --- a/api/test/trace/noop_test.cc +++ b/api/test/trace/noop_test.cc @@ -9,24 +9,25 @@ using opentelemetry::trace::NoopTracer; using opentelemetry::trace::Tracer; -TEST(NoopTest, UseNoopTracers) -{ - // Note: This test is no longer valid as Span no longer has field of tracer. Whether - // removing it depends on the creator of this file. - // std::shared_ptr tracer{new NoopTracer{}}; - // auto s1 = tracer->StartSpan("abc"); - // EXPECT_EQ(&s1->tracer(), tracer.get()); - // - // std::map attributes1; - // s1->AddEvent("abc", attributes1); - // - // std::vector> attributes2; - // s1->AddEvent("abc", attributes2); - // - // s1->AddEvent("abc", {{"a", 1}, {"b", "2"}, {"c", 3.0}}); - // - // std::vector>> attributes3; - // s1->AddEvent("abc", attributes3); - // - // s1->SetAttribute("abc", 4); -} +// Note: This test is no longer valid as Span no longer has field of tracer. Whether +// removing it depends on the creator of this file. +// TEST(NoopTest, UseNoopTracers) +//{ + +// std::shared_ptr tracer{new NoopTracer{}}; +// auto s1 = tracer->StartSpan("abc"); +// EXPECT_EQ(&s1->tracer(), tracer.get()); +// +// std::map attributes1; +// s1->AddEvent("abc", attributes1); +// +// std::vector> attributes2; +// s1->AddEvent("abc", attributes2); +// +// s1->AddEvent("abc", {{"a", 1}, {"b", "2"}, {"c", 3.0}}); +// +// std::vector>> attributes3; +// s1->AddEvent("abc", attributes3); +// +// s1->SetAttribute("abc", 4); +// }