From dd7f65df2fbaf205bcb943a0bf6c5722819e8f5f Mon Sep 17 00:00:00 2001 From: Tianlin Zhao Date: Thu, 20 Aug 2020 21:19:19 -0400 Subject: [PATCH] resolved aditya's questions --- .../trace/propagation/http_trace_context.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/api/include/opentelemetry/trace/propagation/http_trace_context.h b/api/include/opentelemetry/trace/propagation/http_trace_context.h index 00447df90a..20b238fc6d 100644 --- a/api/include/opentelemetry/trace/propagation/http_trace_context.h +++ b/api/include/opentelemetry/trace/propagation/http_trace_context.h @@ -93,7 +93,7 @@ class HttpTraceContext : public HTTPTextFormat } } - static void GenerateBuffer(nostd::string_view string, int bytes, uint8_t &buffer[]) + static void GenerateBuffer(nostd::string_view string, int bytes, uint8_t *buffer) { const char *str_id = string.begin(); for (int i = 0; i < bytes; i++) @@ -120,15 +120,15 @@ class HttpTraceContext : public HTTPTextFormat static TraceId GenerateTraceIdFromString(nostd::string_view trace_id) { - uint8_t buf[kTraceIdBytes / 2] = {0}; - GenerateBuffer(trace_id, kTraceIdBytes, buf); + uint8_t buf[kTraceIdBytes / 2]; + GenerateBuffer(trace_id, kTraceIdBytes, &buf); return TraceId(buf); } static SpanId GenerateSpanIdFromString(nostd::string_view span_id) { - uint8_t buf[kSpanIdBytes / 2] = {0}; - GenerateBuffer(span_id, kSpanIdBytes, buf); + uint8_t buf[kSpanIdBytes / 2]; + GenerateBuffer(span_id, kSpanIdBytes, &buf); return SpanId(buf); }