Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we export opentelemetry_otlp_recordable headers? #1343

Closed
owent opened this issue Apr 21, 2022 · 2 comments · Fixed by #1365
Closed

Could we export opentelemetry_otlp_recordable headers? #1343

owent opened this issue Apr 21, 2022 · 2 comments · Fixed by #1365
Assignees

Comments

@owent
Copy link
Member

owent commented Apr 21, 2022

Is your feature request related to a problem?

I want to implement a special OTLP exporter to extend the standard OTLP exporters,but I need to control the recordable objects of OTLP exporters. But I found I cann't reuse recordables with cmake because the installation exclude the headers of OTLP recordables.

install(
  DIRECTORY include/opentelemetry/exporters/otlp
  DESTINATION include/opentelemetry/exporters
  FILES_MATCHING
  PATTERN "*.h"
  PATTERN "otlp_recordable.h" EXCLUDE)

I just wonder why we exclude otlp_recordable.h here, and can we also install it?

Describe the solution you'd like

Remove PATTERN "otlp_recordable.h" EXCLUDE above.

@ThomsonTan
Copy link
Contributor

the header file was excluded in below PR, probably we should discuss to get it back for installation. @esigo

#923

@lalitb
Copy link
Member

lalitb commented Apr 26, 2022

Yes I think this is valid use-case, we can bring this header file as part of installation. I can fix this next week, unless someone wants to raise a PR to fix this earlier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants