Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFIG] Implement file configuration #2481

Open
36 of 50 tasks
marcalff opened this issue Jan 10, 2024 · 0 comments · May be fixed by #2518
Open
36 of 50 tasks

[CONFIG] Implement file configuration #2481

marcalff opened this issue Jan 10, 2024 · 0 comments · May be fixed by #2518
Assignees
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

marcalff commented Jan 10, 2024

The spec for file configuration is shaping up, opentelemetry-cpp needs to start planning for this.

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/file-configuration.md

Sub tasks:

  • Define the config file format (yaml)
  • Define the config file schema - experimental, see https://github.com/open-telemetry/opentelemetry-configuration
  • Pick a yaml parser
  • Define C++ classes for the config model
    • Propagators.
    • Traces.
    • Metrics.
    • Logs.
  • Implement environment variables substitution from yaml
  • Populate the C++ config model from yaml
    • Propagators.
    • Traces.
    • Metrics.
    • Logs.
  • Instantiate SDK and exporter objects from the C++ config model
    • Propagators.
    • Traces.
    • Metrics.
    • Logs.
  • User documentation
  • Define a registry for plugin components
    • propagators
    • trace plugins
      • samplers
      • span processors
      • span exporters
    • metric plugins
    • logs plugins
  • Populate config model from yaml, for registered third party components
    • propagators
    • trace plugins
      • samplers
      • span processors
      • span exporters
    • metric plugins
    • logs plugins
  • Instantiate plugins from config model, for registered third party components
    • propagators
    • trace plugins
      • samplers
      • span processors
      • span exporters
    • metric plugins
    • logs plugins
  • Third party documentation (for implementing plugins)

Related issues, found while implementing this feature:

@marcalff marcalff added the enhancement New feature or request label Jan 10, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 10, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2024
@marcalff marcalff self-assigned this Jan 15, 2024
@marcalff marcalff linked a pull request Jan 31, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant