Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Release 9.0 Causes a Port Binding Error When Using the Prometheus Exporter #323

Closed
erichsueh3 opened this issue Sep 4, 2020 · 6 comments
Labels
bug Something isn't working do-not-stale metrics priority:p2 Issues that are not blocking release:after-ga To be resolved after GA release

Comments

@erichsueh3
Copy link
Contributor

Is your feature request related to a problem?
Yes. Currently, the OpenTelemetry CPP repo uses the latest release, version 9.0, of the CPP Prometheus client. However, using this release will throw an exception when trying to use the Prometheus Exporter. The exception reads libc++abi.dylib: terminating with uncaught exception of type CivetException: null context when constructing CivetServer. Possible problem binding to port.

Describe the solution you'd like
Until a new release is established, we instead should use the master branch of the CPP Prometheus client. Though this means we won’t be using a stable version, the Prometheus Exporter would work properly and when a newer version is released, that could be the new version to use.

Describe alternatives you've considered
Alternatively, we can keep using version 9.0 and wait for a new version of the Prometheus client to be released. This allows the Prometheus Exporter to be dependent on a stable release; however, the Prometheus Exporter would not work, and a new release may not come soon.

@erichsueh3
Copy link
Contributor Author

This can be done by removing git checkout v0.9.0 in line 52 of ./ci/do_ci.sh.

@pyohannes pyohannes added bug Something isn't working metrics labels Sep 17, 2020
@lalitb lalitb added priority:p2 Issues that are not blocking release:after-ga To be resolved after GA release labels Dec 16, 2020
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 24, 2021
@lalitb lalitb removed the Stale label Nov 24, 2021
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Jan 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Closed as inactive. Feel free to reopen if this is still an issue.

@github-actions github-actions bot closed this as completed Feb 1, 2022
@lalitb lalitb added do-not-stale and removed Stale labels Feb 1, 2022
@lalitb lalitb reopened this Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added Stale and removed Stale labels Apr 2, 2022
@marcalff
Copy link
Member

The port number to use for the prometheus scrape is configurable.

With the following fix:

the documentation to use prometheus has been expanded, and provides details.

When an instrumented process exposes a scrape port, 9464 by default, or as set in:

  • environment variable PROMETHEUS_EXPORTER_ENDPOINT
  • PrometheusExporterOptions::url

the port must be available, so the process can bind to it.

Closing this issue, it is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale metrics priority:p2 Issues that are not blocking release:after-ga To be resolved after GA release
Projects
None yet
Development

No branches or pull requests

4 participants