Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceTest failing #1391

Closed
julianocosta89 opened this issue Feb 19, 2024 · 0 comments · Fixed by #1394
Closed

TraceTest failing #1391

julianocosta89 opened this issue Feb 19, 2024 · 0 comments · Fixed by #1394
Labels
bug Something isn't working v1.9 Issues for the 1.9 release

Comments

@julianocosta89
Copy link
Member

After this PR got merged #1385, the TraceTests are failing due to changes on the semantic conventions.

messaging.destination.kind="topic" is not part of span attributes anymore, but when removing it, we can't get an unique selector.

https://github.com/open-telemetry/opentelemetry-demo/blob/main/test/tracetesting/checkout-service/place-order.yaml#L48
and
https://github.com/open-telemetry/opentelemetry-demo/blob/main/test/tracetesting/frontend-service/06-checking-out-cart.yaml#L62

have the same identifiers.

I've pinged the TraceTest team in order to get some assistance.
@julianocosta89 julianocosta89 added the bug Something isn't working label Feb 19, 2024
@austinlparker austinlparker added the v1.9 Issues for the 1.9 release label Feb 19, 2024
@julianocosta89 julianocosta89 mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v1.9 Issues for the 1.9 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update trace test sem conv julianocosta89/opentelemetry-demo
2 participants
@austinlparker @julianocosta89