Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up manual span attributes and names #280

Closed
3 tasks done
puckpuck opened this issue Aug 10, 2022 · 1 comment
Closed
3 tasks done

Clean up manual span attributes and names #280

puckpuck opened this issue Aug 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@puckpuck
Copy link
Contributor

puckpuck commented Aug 10, 2022 •
edited
Loading

We have (nearly) all services instrumented with manual span attributes. As the number of span attributes grew with contributions from different people and at different times, we have introduced some deviation in the attribute names and intent. This issue is meant to track updating attributes across all services.

  • Remove unnecessary attributes that would not provide value in the service used (ie: shipping total in email service)
  • Normalize names for similar attributes used across multiple services
  • Update names to better reflect industry standards (ie: cost -> amount)
@puckpuck puckpuck added the enhancement New feature or request label Aug 10, 2022
@puckpuck puckpuck mentioned this issue Aug 10, 2022
Merged
@puckpuck
Copy link
Contributor Author

These were resolved with PRs: #333, #334, #335, #336, #337, and #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@puckpuck